Backport initial_max_send_streams support to 0.14.x
#3898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just as a general note, v1 came out 1.5 years ago, and I'm reducing the amount of maintenance done to 0.14. I know there's less initial work if someone else backports, but if a new patch disrupts someone unexpectedly, I need to put more maintenance in a dying branch. That's not to say we can't do this... |
|
Yeah. Luckily it's a clean backport, so risk should be pretty low. Just need a decision on the changed default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the relevant changes from hyperium/h2#731. Happy to drop the changed default if minimizing disruption to existing users is preferred, but I suspect the current behavior is detrimental to most users (see e.g. facebook/buck2#316) and the tweaked default will make things better.